Tidy imports and context use #266
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
Stebalien
requested changes
Feb 15, 2019
|
|
||
| ctx, cancel := context.WithCancel(ctx) | ||
| defer cancel() | ||
|
|
||
| runner := newQueryRunner(q) | ||
| return runner.Run(ctx, peers) |
There was a problem hiding this comment.
So, I did a quick sanity check and dhtQueryRunner.Run is broken. It should be creating a cancelable context and canceling it but it's not. See:
Lines 122 to 123 in 931ed22
There was a problem hiding this comment.
@Stebalien thanks! I'll look into it more and fix that more directly.
|
I need #264 to be merged first, as there's some overlap if the context use is to be cleaned up here. |
|
I'll hold off on this, I have more important things to work on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.